[asterisk-dev] [Code Review] Fax Gateway Implementation T30<->T38

irroot reviewboard at asterisk.org
Fri Feb 25 08:18:35 CST 2011


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1116/
-----------------------------------------------------------

(Updated 2011-02-25 08:18:35.431038)


Review request for Asterisk Developers, Russell Bryant, dimas, Leif Madsen, and dafe_von_cetin.


Changes
-------

Here is a patch that is purely focused on API implementing the gateway in res_fax/res_fax_spandsp the changes to channel.c/h are my proposal 
on how to hook it all in.

have updated mantis where the redundant code is moved into a standalone app calling the the res as a example and also to maintain the 
old method for the existing users.

have a great weekend all im heading home.


Summary
-------

Hi there the patch that was going around circa 2008 to implement this in 1.4/1.6 app_fax has been moved to trunk [1.10]
ive made some cleanups and moved it into res_fax res_fax_spandsp this is the framework and not production code
unfortunately i have no means of testing it at the moment and require help.

i have cleaned the code up substantially it is related to R459

hope this is found useful and aids in the goal to get it in 1.10.

Adds application FaxGateway / FaxDetect
Adds alternate bridge to Dial with new option.


This addresses bug 13405.
    https://issues.asterisk.org/view.php?id=13405


Diffs (updated)
-----

  /trunk/include/asterisk/channel.h 308283 
  /trunk/include/asterisk/res_fax.h 308283 
  /trunk/main/channel.c 308283 
  /trunk/res/res_fax.c 308283 
  /trunk/res/res_fax_spandsp.c 308283 

Diff: https://reviewboard.asterisk.org/r/1116/diff


Testing
-------


Thanks,

irroot

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20110225/c1192c7f/attachment.htm>


More information about the asterisk-dev mailing list