[asterisk-dev] [Code Review] Fax Gateway Implementation T30<->T38

[irroot]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1116/#review3215
-----------------------------------------------------------


ive been striping the bits apart and making them more friendly to * and res_fax

to allow the "Gateway" to manage the T38 parameter's within res_fax i propose a callback
to be placed in the bridge config.

a further callback needs to be added for the actual gateway when the channel states are correct ast_generic_bridge must end and the
gateway start.

"t38_gateway_handle_parameters" res_fax will register this and if FAXOPTS and friends enable T38 Gateway on the call via a option this call back will return a result indicating handled / not handled / T38 Gateway Start.

if it is not handled either due to non existence or if not handled status quo is maintained.

on T38 Gateway start the audio loop must end and the T38 gateway bridge callback must be called this is in res_fax and calls 
technology IE res_fax_spandsp.

this callback will need to go into ast_generic_bridge and replace the current AST_CONTROL_T38_PARAMETERS case.

Please let me know if this method is in line with the API requirements.



- irroot


On 2011-02-23 02:56:49, irroot wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/1116/
> -----------------------------------------------------------
> 
> (Updated 2011-02-23 02:56:49)
> 
> 
> Review request for Asterisk Developers, Russell Bryant, dimas, Leif Madsen, and dafe_von_cetin.
> 
> 
> Summary
> -------
> 
> Hi there the patch that was going around circa 2008 to implement this in 1.4/1.6 app_fax has been moved to trunk [1.10]
> ive made some cleanups and moved it into res_fax res_fax_spandsp this is the framework and not production code
> unfortunately i have no means of testing it at the moment and require help.
> 
> i have cleaned the code up substantially it is related to R459
> 
> hope this is found useful and aids in the goal to get it in 1.10.
> 
> Adds application FaxGateway / FaxDetect
> Adds alternate bridge to Dial with new option.
> 
> 
> This addresses bug 13405.
>     https://issues.asterisk.org/view.php?id=13405
> 
> 
> Diffs
> -----
> 
>   /trunk/apps/app_dial.c 308283 
>   /trunk/include/asterisk/features.h 308283 
>   /trunk/include/asterisk/res_fax.h 308283 
>   /trunk/main/features.c 308283 
>   /trunk/res/res_fax.c 308283 
>   /trunk/res/res_fax_spandsp.c 308283 
> 
> Diff: https://reviewboard.asterisk.org/r/1116/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> irroot
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20110224/acdb75ca/attachment-0001.htm>