[asterisk-dev] [Code Review] Don't try to pickup a call that is already in the middle of a masquerade

[Russell Bryant]

----- Original Message -----
> On Fre, 2011-02-04 at 22:26 +0000, Terry Wilson wrote:
> 
> > https://reviewboard.asterisk.org/r/1094/
> >
> > If A calls B which doesn't answer and C & D both try to do a call
> > pickup, it is possible for ast_pickup_call to answer the call, then
> > fail to masquerade one of the calls because the other one is already
> > in the process of masquerading. This patch checks to see if the
> > channel is in the process of masquerading before call before
> > selecting
> > it for a pickup.
> 
> Shouldn't the check for chan->masq also be added to function
> can_pickup() in file apps/app_directed_pickup.c?

Probably.  :-)

--
Russell Bryant
Digium, Inc.  |  Engineering Manager, Open Source Software
445 Jan Davis Drive NW   -    Huntsville, AL 35806  -  USA
jabber: rbryant at digium.com    -=-    skype: russell-bryant
www.digium.com -=- www.asterisk.org -=- blogs.asterisk.org