[asterisk-dev] [Code Review] Don't try to pickup a call that is already in the middle of a masquerade

Michael Neuhauser mike at firmix.at
Mon Feb 7 10:20:16 CST 2011

On Fre, 2011-02-04 at 22:26 +0000, Terry Wilson wrote:

> https://reviewboard.asterisk.org/r/1094/
> If A calls B which doesn't answer and C & D both try to do a call
> pickup, it is possible for ast_pickup_call to answer the call, then
> fail to masquerade one of the calls because the other one is already
> in the process of masquerading. This patch checks to see if the
> channel is in the process of masquerading before call before selecting
> it for a pickup.

Shouldn't the check for chan->masq also be added to function
can_pickup() in file apps/app_directed_pickup.c?

Dr. Michael Neuhauser                             
Firmix Software GmbH                               mailto:mike at firmix.at
Vienna/Austria/Europe                               tel:+43-1-7890849-30
Linux Development and Services                     http://www.firmix.at/

More information about the asterisk-dev mailing list