[asterisk-dev] [Code Review] Don't try to pickup a call that is already in the middle of a masquerade

[Russell Bryant]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1094/#review3165
-----------------------------------------------------------

Ship it!


- Russell


On 2011-02-04 16:26:57, Terry Wilson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/1094/
> -----------------------------------------------------------
> 
> (Updated 2011-02-04 16:26:57)
> 
> 
> Review request for Asterisk Developers and dvossell.
> 
> 
> Summary
> -------
> 
> If A calls B which doesn't answer and C & D both try to do a call pickup, it is possible for ast_pickup_call to answer the call, then fail to masquerade one of the calls because the other one is already in the process of masquerading. This patch checks to see if the channel is in the process of masquerading before call before selecting it for a pickup.
> 
> 
> Diffs
> -----
> 
>   /branches/1.4/res/res_features.c 306052 
> 
> Diff: https://reviewboard.asterisk.org/r/1094/diff
> 
> 
> Testing
> -------
> 
> I've just tested that a call pickup still works. Since it is a timing-based issue, I haven't been able to recreate it.
> 
> 
> Thanks,
> 
> Terry
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20110205/b7a4368c/attachment.htm>