[asterisk-dev] [Code Review] use ie2str(full_ie) where possible in q931.c

Alec Davis reviewboard at asterisk.org
Wed Dec 21 19:42:18 CST 2011

This is an automatically generated e-mail. To reply, visit:

(Updated Dec. 21, 2011, 7:42 p.m.)

Review request for Asterisk Developers and rmudgett.


As we're using the common dump_redirecting_number() for "Redirecting Number" and "Original Called Number", the strlen if the IE decsription is different, additional debug lines required different indentation for octets 3a and 3b.

Fix: use dynamic printf option '%-*c', by placing the 'prefix' at the far left of the padded string.

pri_message(ctrl, "%-*c Ext: %d  Presentation: %s (%d)",
   indent, prefix, ie->data[1] >> 7, pri_pres2str(ie->data[1] & 0x7f), ie->data[1] & 0x7f);



Only 'dump_channel_id' left is.

Diffs (updated)

  branches/1.4/q931.c 2279 

Diff: https://reviewboard.asterisk.org/r/1633/diff

Testing (updated)

basic calls.
adjust some output formatting as suggested.



-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20111222/a8186187/attachment.htm>

More information about the asterisk-dev mailing list