[asterisk-dev] [Code Review]: use ie2str(full_ie) where possible in q931.c

[rmudgett]

> On Dec. 19, 2011, 11:10 a.m., rmudgett wrote:
> > Looks good other than the items below.
> 
> Alec Davis wrote:
>     I can't commit to libpri, as far as I know, I'll leave it in your capable hands Richard.

I'll commit it for you when you are done.


> On Dec. 19, 2011, 11:10 a.m., rmudgett wrote:
> > branches/1.4/q931.c, lines 1507-1515
> > <https://reviewboard.asterisk.org/r/1633/diff/2/?file=22270#file22270line1507>
> >
> >     Why 'dump_channel_id' left is? :)
> 
> Alec Davis wrote:
>     To keep the formatted output 'formatted' I left it as is, I can change the string array description from "Channel Identification" to "Channel ID"
> 
> rmudgett wrote:
>     I don't think making this use ie2str(full_ie) would mess up the formatting much with the following lines.
>     You could try it to see how it looks and then change the ies[] to "Channel ID" if it doesn't look good.
>     
>     Other places where the dumped name changes:
>     "Called Number" --> "Called Party Number"
>     "Calling Number" --> "Calling Party Number"
>     "Redirecting Number" --> "Redirecting Number" and "Redirecting Number" --> "Original Called Number"
> 
> Alec Davis wrote:
>     "Called Party Number", only outputs one line, so should look ok.
>     
>     "Calling Party Number", outputs 2 lines, thus added 6 spaces to allow for addition of "Party ".
>     
>     "Original Called Number" changed to "Redirecting Number"
>

Don't change "Original Called Number" to "Redirecting Number" in ies[] since it is a different ie!  It is just treated the same.  You were actually making an improvement by having it output the correct name.


- rmudgett


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1633/#review5028
-----------------------------------------------------------


On Dec. 19, 2011, 3:56 a.m., Alec Davis wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/1633/
> -----------------------------------------------------------
> 
> (Updated Dec. 19, 2011, 3:56 a.m.)
> 
> 
> Review request for Asterisk Developers and rmudgett.
> 
> 
> Summary
> -------
> 
> compiles
> 
> Only 'dump_channel_id' left is.
> 
> 
> Diffs
> -----
> 
>   branches/1.4/q931.c 2279 
> 
> Diff: https://reviewboard.asterisk.org/r/1633/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Alec
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20111221/cefeb400/attachment-0001.htm>