[asterisk-dev] [Code Review] use ie2str(full_ie) where possible in q931.c

[Alec Davis]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1633/#review5051
-----------------------------------------------------------



branches/1.4/q931.c
<https://reviewboard.asterisk.org/r/1633/#comment9320>

    see note below, regarding easier way to calculate 'indent' dynamically.



branches/1.4/q931.c
<https://reviewboard.asterisk.org/r/1633/#comment9319>

    There's an easier way to calc indent.
    
    by using the printf %n option.
    
    pri_message(ctrl, "%c %s (len=%2d) [ %nExt: %d.....", prefix, ie2str(full_ie), len, @indent,...
    
    


- Alec


On Dec. 21, 2011, 7:42 p.m., Alec Davis wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/1633/
> -----------------------------------------------------------
> 
> (Updated Dec. 21, 2011, 7:42 p.m.)
> 
> 
> Review request for Asterisk Developers and rmudgett.
> 
> 
> Summary
> -------
> 
> compiles
> 
> Only 'dump_channel_id' left is.
> 
> 
> Diffs
> -----
> 
>   branches/1.4/q931.c 2279 
> 
> Diff: https://reviewboard.asterisk.org/r/1633/diff
> 
> 
> Testing
> -------
> 
> basic calls.
> adjust some output formatting as suggested.
> 
> 
> Thanks,
> 
> Alec
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20111222/a03f0c10/attachment-0001.htm>