[asterisk-dev] [Code Review] Adding CLI Function sip remove subscribes and sip remove subscribe <peer>

[schmidts]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1038/
-----------------------------------------------------------

(Updated 2010-11-30 07:09:20.687200)


Review request for Asterisk Developers and Klaus Darilion.


Changes
-------

thx for your review klaus. i am with you that it should be named sip removed subscriptions and i have changed it that way.

i added 2 manager commands: SIPremovesubscription (with parameter peer) and SIPremovesubscriptions.
I dont know much about AMI and how the response should look like but it works as expacted. 
For the manager_sip_remove_subscriptions function there is for sure a better way to get all parameters i need, but nothing comes to my mind, so be honest and just tell me which would be a better way to implement this ;)


Summary
-------

After testing a clustered Asterisk solution we have noticed that there is no other way to remove subscriptions from a server then to let them time out. If you use distributed device states its possible to get notifys from different asterisk servers, cause the subscription was sent to another asterisk in the cluster, before the old subscription timed out.

With this functions all subscribes or all subscribes from a peer could be removed using a CLI command

Both functions send a terminating notify out to the watcher.

I change the expiry value of this subscribe to -1 to mark these subscribes as removed cause they will exists up to T1 X 64 seconds if the watcher is not reachable.


Diffs (updated)
-----

  trunk/channels/chan_sip.c 296751 

Diff: https://reviewboard.asterisk.org/r/1038/diff


Testing
-------

generate several thousand subscribes with sipp and removed them.


Thanks,

schmidts

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.digium.com/pipermail/asterisk-dev/attachments/20101130/35de0dd6/attachment.htm