[asterisk-dev] [Code Review] queue reload members does not work

[Andrew Parisio]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1039/
-----------------------------------------------------------

Review request for Asterisk Developers.


Summary
-------

queue reload members does pick up on member changes in queues.conf  

There's a block of code that prevents the member reload from ever being executed if the queue already exists.  This will only evaluate to true if you are only reloading members and not reloading all.  The logic in all of the following code handles whether or not it needs to be executed based on all/members, so this logic seems both feature breaking and redundant.


Diffs
-----

  /trunk/apps/app_queue.c 296652 

Diff: https://reviewboard.asterisk.org/r/1039/diff


Testing
-------

queue reload members and queue reload all to verify adding/removing of members works properly.


Thanks,

Andrew

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.digium.com/pipermail/asterisk-dev/attachments/20101129/71362d99/attachment.htm