[asterisk-dev] [Code Review] Adding CLI Function sip remove subscribes and sip remove subscribe <peer>

[Klaus Darilion]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1038/#review2984
-----------------------------------------------------------



trunk/channels/chan_sip.c
<https://reviewboard.asterisk.org/r/1038/#comment6208>

    search and replace most: subscribe(s) -> subscription(s)



trunk/channels/chan_sip.c
<https://reviewboard.asterisk.org/r/1038/#comment6207>

    "      Terminate all SIP subscriptions from a certain peer by sending NOTIFYs with subscription-state \"terminated\""



trunk/channels/chan_sip.c
<https://reviewboard.asterisk.org/r/1038/#comment6204>

    Current CLI command is: "sip show subscriptions". Thus I suggest to rename it to "sip remove subscriptions" and rename the other comamnd to "sip remove subscription ....."



trunk/channels/chan_sip.c
<https://reviewboard.asterisk.org/r/1038/#comment6206>

    "      Terminate all SIP subscriptions by sending NOTIFY with subscription-state \"terminated\""



trunk/channels/chan_sip.c
<https://reviewboard.asterisk.org/r/1038/#comment6205>

    plurar: subscriptions


- Klaus


On 2010-11-29 07:52:57, schmidts wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/1038/
> -----------------------------------------------------------
> 
> (Updated 2010-11-29 07:52:57)
> 
> 
> Review request for Asterisk Developers and Klaus Darilion.
> 
> 
> Summary
> -------
> 
> After testing a clustered Asterisk solution we have noticed that there is no other way to remove subscriptions from a server then to let them time out. If you use distributed device states its possible to get notifys from different asterisk servers, cause the subscription was sent to another asterisk in the cluster, before the old subscription timed out.
> 
> With this functions all subscribes or all subscribes from a peer could be removed using a CLI command
> 
> Both functions send a terminating notify out to the watcher.
> 
> I change the expiry value of this subscribe to -1 to mark these subscribes as removed cause they will exists up to T1 X 64 seconds if the watcher is not reachable.
> 
> 
> Diffs
> -----
> 
>   trunk/channels/chan_sip.c 295786 
> 
> Diff: https://reviewboard.asterisk.org/r/1038/diff
> 
> 
> Testing
> -------
> 
> generate several thousand subscribes with sipp and removed them.
> 
> 
> Thanks,
> 
> schmidts
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.digium.com/pipermail/asterisk-dev/attachments/20101130/53b5a1de/attachment-0001.htm