[asterisk-dev] [Code Review] Add error checking to DEADLOCK_AVOIDANCE macro
Tilghman Lesher
tlesher at digium.com
Mon Jun 28 13:36:49 CDT 2010
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/751/
-----------------------------------------------------------
Review request for Asterisk Developers.
Summary
-------
If DEADLOCK_AVOIDANCE is called in a situation where the lock is not held, a deadlock could result. While this is a programming error, we should at the very least send up a warning about the problem.
This addresses bug 17407.
https://issues.asterisk.org/view.php?id=17407
Diffs
-----
/branches/1.4/channels/chan_agent.c 266141
/branches/1.4/channels/chan_dahdi.c 266141
/branches/1.4/channels/chan_h323.c 266141
/branches/1.4/channels/chan_local.c 266141
/branches/1.4/include/asterisk/lock.h 266141
Diff: https://reviewboard.asterisk.org/r/751/diff
Testing
-------
No functional changes. Runs better according to reporter.
Thanks,
Tilghman
More information about the asterisk-dev
mailing list