[asterisk-dev] [Code Review] Backport unit test API to 1.4

David Vossel dvossel at digium.com
Mon Jun 28 13:32:40 CDT 2010


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/750/#review2295
-----------------------------------------------------------

Ship it!


Great work!

- David


On 2010-06-28 12:52:04, Russell Bryant wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/750/
> -----------------------------------------------------------
> 
> (Updated 2010-06-28 12:52:04)
> 
> 
> Review request for Asterisk Developers and David Vossel.
> 
> 
> Summary
> -------
> 
> This set of changes backports the unit test API to Asterisk 1.4.  The changes to get this into 1.4 were more extensive than the backport to 1.6.2.  Most notably, Asterisk 1.4 lacks the ast_str API and the ast_cli API is very different.
> 
> I added a tests directory and added the test_skel module.  That is currently the only unit test that gets registered when you build with TEST_FRAMEWORK.
> 
> 
> Diffs
> -----
> 
>   /branches/1.4/Makefile 272808 
>   /branches/1.4/build_tools/cflags-devmode.xml 272808 
>   /branches/1.4/include/asterisk.h 272808 
>   /branches/1.4/include/asterisk/linkedlists.h 272808 
>   /branches/1.4/include/asterisk/test.h PRE-CREATION 
>   /branches/1.4/main/Makefile 272808 
>   /branches/1.4/main/asterisk.c 272808 
>   /branches/1.4/main/test.c PRE-CREATION 
> 
> Diff: https://reviewboard.asterisk.org/r/750/diff
> 
> 
> Testing
> -------
> 
> I built Asterisk with TEST_FRAMEWORK, and went through the CLI commands verifying that they do what I expected.
> 
> 
> Thanks,
> 
> Russell
> 
>




More information about the asterisk-dev mailing list