[asterisk-dev] [Code Review] Remove need for registration strings in sip.conf

Nick Lewis Nick.Lewis at atltelecom.com
Wed Jun 23 11:03:32 CDT 2010


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/718/
-----------------------------------------------------------

(Updated 2010-06-23 11:03:32.317367)


Review request for Asterisk Developers and David Vossel.


Changes
-------

Updated DEVICE CONFIGURATION section of sip.conf.sample. Included registration from peer specific configuration in register_count. Added untested realtime_register() function to try to address realtime registration concerns


Summary
-------

This change adds the ability to specify the sip registration expiry and registrar host to the peer configuration items. This permits all registration details that are available to the registration string to be also available to the peer definitions. The users of sip.conf can enable registration by setting register=yes in the peer and do not need to concern themselves with the strange format of the registration strings

Suggest inclusion in 1.8


Diffs (updated)
-----

  trunk/channels/chan_sip.c 268968 
  trunk/channels/sip/config_parser.c 268968 
  trunk/channels/sip/include/sip.h 268968 
  trunk/configs/sip.conf.sample 268968 

Diff: https://reviewboard.asterisk.org/r/718/diff


Testing
-------

Compile, run and confirm in cli sip show registry


Thanks,

Nick




More information about the asterisk-dev mailing list