[asterisk-dev] [Code Review] Remove need for registration strings in sip.conf

[David Vossel]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/718/#review2255
-----------------------------------------------------------


more comments!


trunk/channels/chan_sip.c
<https://reviewboard.asterisk.org/r/718/#comment4767>

    This is clever, but I don't think it will work the way you expect it to yet unless that peer is in the 'peers' ao2_container.   When 'the_mark' is set on a reload, only the peers in the 'peers' container are removed that have the_mark.  I don't think build_peer() puts the peer in that container.  



trunk/configs/sip.conf.sample
<https://reviewboard.asterisk.org/r/718/#comment4765>

    Does it make sense for this option to be called 'callbackexpiry'? or should it be something like 'registerexpiry'?



trunk/configs/sip.conf.sample
<https://reviewboard.asterisk.org/r/718/#comment4764>

    I don't understand the need for this option.  We already have the  'callbackextension' option, and changing the behavior to always default to an extension matching the peer name would not be something I'd expect.
    
    I'd prefer that the default callback remain 's' unless otherwise specified by the 'callbackextension' option. 



trunk/configs/sip.conf.sample
<https://reviewboard.asterisk.org/r/718/#comment4766>

    If we change don't make the default callback extension the peer name this example will have to change again.


- David


On 2010-06-23 11:03:32, Nick Lewis wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/718/
> -----------------------------------------------------------
> 
> (Updated 2010-06-23 11:03:32)
> 
> 
> Review request for Asterisk Developers and David Vossel.
> 
> 
> Summary
> -------
> 
> This change adds the ability to specify the sip registration expiry and registrar host to the peer configuration items. This permits all registration details that are available to the registration string to be also available to the peer definitions. The users of sip.conf can enable registration by setting register=yes in the peer and do not need to concern themselves with the strange format of the registration strings
> 
> Suggest inclusion in 1.8
> 
> 
> Diffs
> -----
> 
>   trunk/channels/chan_sip.c 268968 
>   trunk/channels/sip/config_parser.c 268968 
>   trunk/channels/sip/include/sip.h 268968 
>   trunk/configs/sip.conf.sample 268968 
> 
> Diff: https://reviewboard.asterisk.org/r/718/diff
> 
> 
> Testing
> -------
> 
> Compile, run and confirm in cli sip show registry
> 
> 
> Thanks,
> 
> Nick
> 
>