[asterisk-dev] [Code Review] Remove need for registration strings in sip.conf

[Nick Lewis]

> On 2010-06-18 08:59:24, pabelanger wrote:
> > trunk/channels/chan_sip.c, line 25419
> > <https://reviewboard.asterisk.org/r/718/diff/3/?file=10915#file10915line25419>
> >
> >     I'm trying to understand why you created this setting?  Since we already have host.
> >     
> >     For example?
> >     [provider]
> >     type=peer
> >     register=yes
> >     host=a.example.com
> >     registrarhost=b.example.com
> >     ...
> >     ...
> >     
> >     Would that be a valid configuration?

Yes 

This is equivalent to a registration string:

register => user at a.example.com@b.example.com

and sip message:

REGISTER sip:b.example.com SIP/2.0
To: sip:user at a.example.com
From: sip:user at a.example.com

See reference to registrar configuration in RFC3261 Section 10.2.6 


> On 2010-06-18 08:59:24, pabelanger wrote:
> > trunk/configs/sip.conf.sample, lines 603-606
> > <https://reviewboard.asterisk.org/r/718/diff/3/?file=10918#file10918line603>
> >
> >     Is the plan to actually depreciate this method?  If so, we should also include a warning message.

I do not wish to discriminate against masochists


> On 2010-06-18 08:59:24, pabelanger wrote:
> > trunk/configs/sip.conf.sample, line 970
> > <https://reviewboard.asterisk.org/r/718/diff/3/?file=10918#file10918line970>
> >
> >     Also include new options in the list below.

Will do


- Nick


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/718/#review2230
-----------------------------------------------------------


On 2010-06-17 10:01:52, Nick Lewis wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/718/
> -----------------------------------------------------------
> 
> (Updated 2010-06-17 10:01:52)
> 
> 
> Review request for Asterisk Developers and David Vossel.
> 
> 
> Summary
> -------
> 
> This change adds the ability to specify the sip registration expiry and registrar host to the peer configuration items. This permits all registration details that are available to the registration string to be also available to the peer definitions. The users of sip.conf can enable registration by setting register=yes in the peer and do not need to concern themselves with the strange format of the registration strings
> 
> Suggest inclusion in 1.8
> 
> 
> Diffs
> -----
> 
>   trunk/channels/chan_sip.c 268968 
>   trunk/channels/sip/config_parser.c 268968 
>   trunk/channels/sip/include/sip.h 268968 
>   trunk/configs/sip.conf.sample 268968 
> 
> Diff: https://reviewboard.asterisk.org/r/718/diff
> 
> 
> Testing
> -------
> 
> Compile, run and confirm in cli sip show registry
> 
> 
> Thanks,
> 
> Nick
> 
>