[asterisk-dev] [Code Review] Remove need for registration strings in sip.conf

[paul.belanger at polybeacon.com]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/718/#review2230
-----------------------------------------------------------


I also agree!  This is a welcomed feature for Asterisk.  I have a question below.


trunk/channels/chan_sip.c
<https://reviewboard.asterisk.org/r/718/#comment4733>

    I'm trying to understand why you created this setting?  Since we already have host.
    
    For example?
    [provider]
    type=peer
    register=yes
    host=a.example.com
    registrarhost=b.example.com
    ...
    ...
    
    Would that be a valid configuration?



trunk/configs/sip.conf.sample
<https://reviewboard.asterisk.org/r/718/#comment4731>

    Is the plan to actually depreciate this method?  If so, we should also include a warning message.



trunk/configs/sip.conf.sample
<https://reviewboard.asterisk.org/r/718/#comment4732>

    Also include new options in the list below.


- pabelanger


On 2010-06-17 10:01:52, Nick Lewis wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/718/
> -----------------------------------------------------------
> 
> (Updated 2010-06-17 10:01:52)
> 
> 
> Review request for Asterisk Developers and David Vossel.
> 
> 
> Summary
> -------
> 
> This change adds the ability to specify the sip registration expiry and registrar host to the peer configuration items. This permits all registration details that are available to the registration string to be also available to the peer definitions. The users of sip.conf can enable registration by setting register=yes in the peer and do not need to concern themselves with the strange format of the registration strings
> 
> Suggest inclusion in 1.8
> 
> 
> Diffs
> -----
> 
>   trunk/channels/chan_sip.c 268968 
>   trunk/channels/sip/config_parser.c 268968 
>   trunk/channels/sip/include/sip.h 268968 
>   trunk/configs/sip.conf.sample 268968 
> 
> Diff: https://reviewboard.asterisk.org/r/718/diff
> 
> 
> Testing
> -------
> 
> Compile, run and confirm in cli sip show registry
> 
> 
> Thanks,
> 
> Nick
> 
>