[asterisk-dev] [Code Review] ast_callerid restructuring

[Richard Mudgett]

----- Original Message -----
> On 2010-06-11 00:13, rmudgett at digium.com wrote:
> 
> >
> > Summary
> > -------
> >
> > The purpose of this patch is to eliminate struct ast_callerid since
> > it has
> > turned into a miscellaneous collection of various party information.
> >
> > Eliminate struct ast_callerid and replace it with the following
> > struct
> > organization:
> >
> > struct ast_party_name {
> > 	char *str;
> > 	int char_set;
> > 	int presentation;
> > 	unsigned char valid;
> > }; struct ast_party_number {
> > 	char *str;
> > 	int plan;
> > 	int presentation;
> > 	unsigned char valid;
> > };
> Why isn't there a type of number field in struct ast_party_number ?
> 
The type of number is part of the plan field.  The doxygen comment for the field even states this.  It is just an internal name change from number_type since the field also contained the numbering plan.

Richard