[asterisk-dev] [Code Review] Add ability to set Max-Forwards header from dialplan, general and device configuration

[Olle E Johansson]

> On 2010-07-13 13:11:52, David Vossel wrote:
> > /trunk/channels/chan_sip.c, line 26562
> > <https://reviewboard.asterisk.org/r/778/diff/1/?file=11547#file11547line26562>
> >
> >     Using sscanf will let you detect a config error here which seems like it would be a good idea.  If this isn't a valid unsigned int, a log error should be generated and the default should remain.

Good suggestions, thanks.


> On 2010-07-13 13:11:52, David Vossel wrote:
> > /trunk/configs/sip.conf.sample, line 205
> > <https://reviewboard.asterisk.org/r/778/diff/1/?file=11549#file11549line205>
> >
> >     It might be useful explicitly state what the default value is here when this option is not enabled.

Fixed.


- Olle E


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/778/#review2379
-----------------------------------------------------------


On 2010-07-13 11:29:08, Olle E Johansson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/778/
> -----------------------------------------------------------
> 
> (Updated 2010-07-13 11:29:08)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> This change adds the ability to set the value of the Max-Forwards header from the Asterisk dialplan and from sip.conf - the general section and per device. 
> 
> 
> Diffs
> -----
> 
>   /trunk/channels/chan_sip.c 275912 
>   /trunk/channels/sip/include/sip.h 275912 
>   /trunk/configs/sip.conf.sample 275912 
>   /trunk/doc/tex/channelvariables.tex 275912 
> 
> Diff: https://reviewboard.asterisk.org/r/778/diff
> 
> 
> Testing
> -------
> 
> The 1.4 version has been in use with the dialplan support for a few weeks. The device config is new.
> 
> 
> Thanks,
> 
> Olle E
> 
>