[asterisk-dev] [Code Review] Add ability to set Max-Forwards header from dialplan, general and device configuration

[Olle E. Johansson]

13 jul 2010 kl. 20.11 skrev David Vossel:

> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/778/#review2379
> -----------------------------------------------------------
> 
> Ship it!
> 
> 
> Nice work!  I just had a few minor comments.
> 
> 
> /trunk/channels/chan_sip.c
> <https://reviewboard.asterisk.org/r/778/#comment5259>
> 
>    Using sscanf will let you detect a config error here which seems like it would be a good idea.  If this isn't a valid unsigned int, a log error should be generated and the default should remain.
> 
Good feedback. Thanks.
> 
> 
> /trunk/configs/sip.conf.sample
> <https://reviewboard.asterisk.org/r/778/#comment5260>
> 
>    It might be useful explicitly state what the default value is here when this option is not enabled.
Absolutely. 

/O
> 
> 
> - David
> 
> 
> On 2010-07-13 11:29:08, Olle E Johansson wrote:
>> 
>> -----------------------------------------------------------
>> This is an automatically generated e-mail. To reply, visit:
>> https://reviewboard.asterisk.org/r/778/
>> -----------------------------------------------------------
>> 
>> (Updated 2010-07-13 11:29:08)
>> 
>> 
>> Review request for Asterisk Developers.
>> 
>> 
>> Summary
>> -------
>> 
>> This change adds the ability to set the value of the Max-Forwards header from the Asterisk dialplan and from sip.conf - the general section and per device. 
>> 
>> 
>> Diffs
>> -----
>> 
>>  /trunk/channels/chan_sip.c 275912 
>>  /trunk/channels/sip/include/sip.h 275912 
>>  /trunk/configs/sip.conf.sample 275912 
>>  /trunk/doc/tex/channelvariables.tex 275912 
>> 
>> Diff: https://reviewboard.asterisk.org/r/778/diff
>> 
>> 
>> Testing
>> -------
>> 
>> The 1.4 version has been in use with the dialplan support for a few weeks. The device config is new.
>> 
>> 
>> Thanks,
>> 
>> Olle E
>> 
>> 

---
* Olle E Johansson - oej at edvina.net
* Cell phone +46 70 593 68 51, Office +46 8 96 40 20, Sweden