[asterisk-dev] [Code Review] GSOC 2010 - Data API providers

[Eliel Sardañons]

> On 2010-07-02 08:44:22, pabelanger wrote:
> > /trunk/apps/app_queue.c, line 7768
> > <https://reviewboard.asterisk.org/r/757/diff/2/?file=11223#file11223line7768>
> >
> >     Removed by mistake?

no, it is correct.


> On 2010-07-02 08:44:22, pabelanger wrote:
> > /trunk/channels/chan_agent.c, line 2333
> > <https://reviewboard.asterisk.org/r/757/diff/2/?file=11225#file11225line2333>
> >
> >     blob

thanks


> On 2010-07-02 08:44:22, pabelanger wrote:
> > /trunk/channels/chan_dahdi.c, line 17474
> > <https://reviewboard.asterisk.org/r/757/diff/2/?file=11226#file11226line17474>
> >
> >     same

thanks


> On 2010-07-02 08:44:22, pabelanger wrote:
> > /trunk/channels/chan_dahdi.c, lines 17502-17515
> > <https://reviewboard.asterisk.org/r/757/diff/2/?file=11226#file11226line17502>
> >
> >     braces for if statements.

thanks


> On 2010-07-02 08:44:22, pabelanger wrote:
> > /trunk/channels/chan_dahdi.c, lines 17521-17524
> > <https://reviewboard.asterisk.org/r/757/diff/2/?file=11226#file11226line17521>
> >
> >     braces and blob.

thanks


> On 2010-07-02 08:44:22, pabelanger wrote:
> > /trunk/channels/chan_iax2.c, lines 13947-13949
> > <https://reviewboard.asterisk.org/r/757/diff/2/?file=11227#file11227line13947>
> >
> >     Would you not need to unlink here?  Trying to understand ao2_link/ao2_unlink.
> >     
> >     ao2_unlink(users, user);

you are right.


> On 2010-07-02 08:44:22, pabelanger wrote:
> > /trunk/apps/app_meetme.c, lines 6747-6750
> > <https://reviewboard.asterisk.org/r/757/diff/2/?file=11222#file11222line6747>
> >
> >     Reading though the CODING-GUIDELINES you'll also need to include the \since 1.8 flag for all new functions.

The API was already implemented, this is not part of the API.


- Eliel


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/757/#review2325
-----------------------------------------------------------


On 2010-06-29 22:27:37, Eliel Sardañons wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/757/
> -----------------------------------------------------------
> 
> (Updated 2010-06-29 22:27:37)
> 
> 
> Review request for Asterisk Developers and Tilghman Lesher.
> 
> 
> Summary
> -------
> 
> Data API providers already implemented for the summer of code 2010 project
> 
> 
> Diffs
> -----
> 
>   /trunk/apps/app_meetme.c 273179 
>   /trunk/apps/app_queue.c 273179 
>   /trunk/apps/app_voicemail.c 273179 
>   /trunk/channels/chan_agent.c 273179 
>   /trunk/channels/chan_dahdi.c 273179 
>   /trunk/channels/chan_iax2.c 273179 
>   /trunk/channels/chan_sip.c 273179 
>   /trunk/include/asterisk/cdr.h 273179 
>   /trunk/include/asterisk/channel.h 273179 
>   /trunk/include/asterisk/data.h 273179 
>   /trunk/include/asterisk/indications.h 273179 
>   /trunk/main/cdr.c 273179 
>   /trunk/main/channel.c 273179 
>   /trunk/main/data.c 273179 
>   /trunk/main/indications.c 273179 
>   /trunk/res/res_odbc.c 273179 
> 
> Diff: https://reviewboard.asterisk.org/r/757/diff
> 
> 
> Testing
> -------
> 
> Developer testing.
> 
> 
> Thanks,
> 
> Eliel
> 
>