[asterisk-dev] [Code Review] GSOC 2010 - Data API providers

[paul.belanger at polybeacon.com]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/757/#review2325
-----------------------------------------------------------


Peer review. Plus a few questions.  I'm eager to give this a try, good work.


/trunk/apps/app_meetme.c
<https://reviewboard.asterisk.org/r/757/#comment5075>

    Reading though the CODING-GUIDELINES you'll also need to include the \since 1.8 flag for all new functions.



/trunk/apps/app_queue.c
<https://reviewboard.asterisk.org/r/757/#comment5076>

    Removed by mistake?



/trunk/channels/chan_agent.c
<https://reviewboard.asterisk.org/r/757/#comment5077>

    blob



/trunk/channels/chan_dahdi.c
<https://reviewboard.asterisk.org/r/757/#comment5078>

    same



/trunk/channels/chan_dahdi.c
<https://reviewboard.asterisk.org/r/757/#comment5079>

    braces for if statements.



/trunk/channels/chan_dahdi.c
<https://reviewboard.asterisk.org/r/757/#comment5080>

    braces and blob.



/trunk/channels/chan_iax2.c
<https://reviewboard.asterisk.org/r/757/#comment5081>

    blob



/trunk/channels/chan_iax2.c
<https://reviewboard.asterisk.org/r/757/#comment5082>

    Would you not need to unlink here?  Trying to understand ao2_link/ao2_unlink.
    
    ao2_unlink(users, user);



/trunk/res/res_odbc.c
<https://reviewboard.asterisk.org/r/757/#comment5083>

    blob


- pabelanger


On 2010-06-29 22:27:37, Eliel Sardañons wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/757/
> -----------------------------------------------------------
> 
> (Updated 2010-06-29 22:27:37)
> 
> 
> Review request for Asterisk Developers and Tilghman Lesher.
> 
> 
> Summary
> -------
> 
> Data API providers already implemented for the summer of code 2010 project
> 
> 
> Diffs
> -----
> 
>   /trunk/apps/app_meetme.c 273179 
>   /trunk/apps/app_queue.c 273179 
>   /trunk/apps/app_voicemail.c 273179 
>   /trunk/channels/chan_agent.c 273179 
>   /trunk/channels/chan_dahdi.c 273179 
>   /trunk/channels/chan_iax2.c 273179 
>   /trunk/channels/chan_sip.c 273179 
>   /trunk/include/asterisk/cdr.h 273179 
>   /trunk/include/asterisk/channel.h 273179 
>   /trunk/include/asterisk/data.h 273179 
>   /trunk/include/asterisk/indications.h 273179 
>   /trunk/main/cdr.c 273179 
>   /trunk/main/channel.c 273179 
>   /trunk/main/data.c 273179 
>   /trunk/main/indications.c 273179 
>   /trunk/res/res_odbc.c 273179 
> 
> Diff: https://reviewboard.asterisk.org/r/757/diff
> 
> 
> Testing
> -------
> 
> Developer testing.
> 
> 
> Thanks,
> 
> Eliel
> 
>