[asterisk-dev] [Code Review] python TestCase class

[Paul Belanger]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1054/
-----------------------------------------------------------

(Updated 2010-12-16 14:35:49.378230)


Review request for Asterisk Developers.


Changes
-------

more updates:
Use the AMI instance ID to determine which AMI we are connected too.
Add first attempt for valgrind


Summary
-------

Warning: This is a work in progress

I wanted to get some initial feedback about creating an Asterisk TestCase class, tests in the testsuite can inherit.  For this first review I have converted 2 tests to use the new TestCase class.

See my inline comments further info, and feedback is required :) 


Diffs (updated)
-----

  asterisk/trunk/configs/asterisk.options.conf.inc 1227 
  asterisk/trunk/configs/manager.conf PRE-CREATION 
  asterisk/trunk/configs/manager.general.conf.inc PRE-CREATION 
  asterisk/trunk/lib/python/asterisk/TestCase.py PRE-CREATION 
  asterisk/trunk/lib/python/asterisk/__init__.py 1227 
  asterisk/trunk/lib/python/asterisk/asterisk.py 1227 
  asterisk/trunk/runtests.py 1227 
  asterisk/trunk/tests/manager/login/run-test 1227 
  asterisk/trunk/tests/udptl/configs/ast1/manager.conf 1227 
  asterisk/trunk/tests/udptl/configs/ast1/manager.general.conf.inc PRE-CREATION 
  asterisk/trunk/tests/udptl/configs/ast2/manager.conf 1227 
  asterisk/trunk/tests/udptl/configs/ast2/manager.general.conf.inc PRE-CREATION 
  asterisk/trunk/tests/udptl/run-test 1227 

Diff: https://reviewboard.asterisk.org/r/1054/diff


Testing
-------

Local development box


Thanks,

Paul

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20101216/e7827827/attachment.htm>