[asterisk-dev] [Code Review] python TestCase class

[Paul Belanger]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1054/#review3031
-----------------------------------------------------------



asterisk/trunk/lib/python/asterisk/TestCase.py
<https://reviewboard.asterisk.org/r/1054/#comment6244>

    After looking at this more, I'm going to suggest we patch starpy, creating a new 'id' member we can set when we create an instance of AMIFactory.
    
    We can then access the value via ami.id and add logic for which instance we want.


- Paul


On 2010-12-09 12:44:06, Paul Belanger wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/1054/
> -----------------------------------------------------------
> 
> (Updated 2010-12-09 12:44:06)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> Warning: This is a work in progress
> 
> I wanted to get some initial feedback about creating an Asterisk TestCase class, tests in the testsuite can inherit.  For this first review I have converted 2 tests to use the new TestCase class.
> 
> See my inline comments further info, and feedback is required :) 
> 
> 
> Diffs
> -----
> 
>   asterisk/trunk/lib/python/asterisk/TestCase.py PRE-CREATION 
>   asterisk/trunk/lib/python/asterisk/__init__.py 1120 
>   asterisk/trunk/lib/python/asterisk/asterisk.py 1120 
>   asterisk/trunk/runtests.py 1120 
>   asterisk/trunk/tests/manager/login/run-test 1120 
>   asterisk/trunk/tests/udptl/configs/ast2/manager.conf 1120 
>   asterisk/trunk/tests/udptl/run-test 1120 
> 
> Diff: https://reviewboard.asterisk.org/r/1054/diff
> 
> 
> Testing
> -------
> 
> Local development box
> 
> 
> Thanks,
> 
> Paul
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20101215/ffc2e5b6/attachment.htm>