[asterisk-dev] Queue stats resetting on reload. Trying to engage the community...

[Jamuel Starkey]

+1

From: asterisk-dev-bounces at lists.digium.com [mailto:asterisk-dev-bounces at lists.digium.com] On Behalf Of Steve Murphy
Sent: Monday, August 16, 2010 10:31 AM
To: Asterisk Developers Mailing List
Subject: Re: [asterisk-dev] Queue stats resetting on reload. Trying to engage the community...

As a community member, I vote to include this in not only the future releases, but in existing
releases. My reasoning is that several gui's front end the config files, and any small mods will
erase stats. Since Ron's fixes won't change behavior, but allow 'expected' behavior to happen,
I see this as a bug fix.

Just my 2 cents,

murf

On Mon, Aug 16, 2010 at 10:48 AM, Ron Arts <ron.arts at netland.nl<mailto:ron.arts at netland.nl>> wrote:
Op 16-08-10 18:27, Mark Michelson schreef:
> On Mon, 2010-08-16 at 17:51 +0200, Ron Arts wrote:
>> Hi,
>>
>> At the moment in 1.6.x and 1.8 beta, a queue reload clears the queue stat counters.
>> I put in a bug report about that, and provided a patch, but it was rejected,
>> because it seems to be expected behaviour as per comments by russellb.
>>
>> When warlock52 reported this as a bug a few days ago, pabelanger suggested to
>> involve the community. So that's what I'm doing now.
>>
>> Is it to be expected that the queue stats are cleared when a CLI queue reload
>> is issued? I do reloads during the day, and my customers do not appreciate
>> the per-agent call counters, and last call time etc being cleared, because
>> it immediately affects their queue processing.
>>
>> What is the reason this is implemented this way?
>>
>> Thanks,
>> Ron
>>
>
> When the "queue reload" command was added in 1.6.2, the idea was to make
> it behave the same way as the command "module reload app_queue.so" from
> previous versions. That command reset statistics, and so the new command
> did the same.
>
> Now as to why it worked that way prior to 1.6.2...your guess is as good
> as mine there. How did your proposed patch work? If it just
> unequivocally turned off stat resetting during a reload, it makes sense
> why it would be rejected since there may be those who rely on such
> behavior and changing it mid-release is a bad idea. One idea that could
> be looked into would be to add a qualifier to the end of the "queue
> reload" command that indicates that you do not wish to also be resetting
> the statistics. Even so, I'm not sure that would make it into 1.6.2
> though.
>
My patch added a keepstats=yes option in queues.conf which defaulted to
'no', so the default behaviour would retained.

Ron

> Mark Michelson
>
>


--
Netland Internet Services BV
bedrijfsmatige internetoplossingen

http://www.netland.nl  Science Park 140           1098 XG Amsterdam
info: 020-5628282      servicedesk: 020-5628282   fax: 020-5628281
KvK Amsterdam 33253286

Op dit bericht is de volgende disclaimer van toepassing:
http://www.netland.nl/maildisclaimer

--
_____________________________________________________________________
-- Bandwidth and Colocation Provided by http://www.api-digital.com --

asterisk-dev mailing list
To UNSUBSCRIBE or update options visit:
  http://lists.digium.com/mailman/listinfo/asterisk-dev



--
Steve Murphy
ParseTree Corp
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.digium.com/pipermail/asterisk-dev/attachments/20100816/9a9ac2f6/attachment.htm