[asterisk-dev] [Code Review] ETSI Explicit Call Transfer (ECT) support. (libpri portion)

[rmudgett at digium.com]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/521/
-----------------------------------------------------------

(Updated 2010-04-22 11:29:20.082752)


Review request for Asterisk Developers.


Changes
-------

Address review comments.

Also made PTMP NT ECT more robust.


Summary
-------

Added ability to send and receive ETSI Explicit Call Transfer (ECT) messages to eliminate tromboned calls.

Added ETSI support to an existing API call to send ECT messages when the upper level indicates to transfer specified calls.

The libpri API was extended to indicate to the upper layer that the far end requests the transfer of the indicated calls.

This is a two part review request.  Asterisk and libpri.  This is the libpri portion.
https://reviewboard.asterisk.org/r/520/ is the asterisk portion.

Note: This change is based off of the libpri/team/group/ccss branch because of needed infrastructure improvements done in that branch.


Diffs (updated)
-----

  /team/group/ccss/libpri.h 1631 
  /team/group/ccss/pri.c 1631 
  /team/group/ccss/pri_facility.h 1631 
  /team/group/ccss/pri_facility.c 1631 
  /team/group/ccss/pri_internal.h 1631 
  /team/group/ccss/q931.c 1631 

Diff: https://reviewboard.asterisk.org/r/521/diff


Testing
-------

A -- *1 -- *2  -- B&C

Party A is on an ISDN phone.

A calls B
A puts B on hold
A calls C
A hangs up to initiate transfer
The B and C parties are now connected to each other and the calls are only connected through *2.

A calls B
A puts B on hold
A calls C
A puts C on hold to retrieve B
A hangs up to initiate transfer
The B and C parties are now connected to each other and the calls are only connected through *2.

Repeat the above two tests but party A uses the EctExecute message instead of disconnecting to transfer the calls.

All four tests passed.


Thanks,

rmudgett