[asterisk-dev] [Code Review] Explicit context set in SIP peer overridden by default domain context

[Nick Lewis]

> On 2010-04-22 11:19:12, Nick Lewis wrote:
> > branches/1.6.2/channels/chan_sip.c, line 23844
> > <https://reviewboard.asterisk.org/r/565/diff/3/?file=9186#file9186line23844>
> >
> >     ast_set_flag(&p->flags[1], SIP_PAGE2_HAVEPEER);
> 
> pprindeville wrote:
>     Ummm.... not sure I follow this comment.  What are you saying?
>

Sorry, I was trying to say set the flag here rather than in the other two places. Obviously the name of the flag could be changed to better represent its new purpose e.g. SIP_PAGE2_HAVEPEERCONTEXT rather than SIP_PAGE2_HAVEPEERMATCH


- Nick


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/565/#review1885
-----------------------------------------------------------


On 2010-04-09 14:41:36, pprindeville wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/565/
> -----------------------------------------------------------
> 
> (Updated 2010-04-09 14:41:36)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> Having inbound SIP 'guest' calls associated to a default context is
> handy, especially when multi-tenancy or hosting multiple domains is
> being done.
> 
> However, the code as written will clobber an explicitly configured
> context associated with a peer if a domain-list is configured.
> 
> This is counter-intuitive, since (a) explicit configuration should
> always trump default or implicit config, and (b) puts all internal
> domain-bound SIP handsets in the same context as guest callers, making
> it hard to apply a restricted dialplan to guest callers.
> 
> 
> This addresses bug 17040.
>     https://issues.asterisk.org/view.php?id=17040
> 
> 
> Diffs
> -----
> 
>   branches/1.6.2/channels/chan_sip.c 256425 
> 
> Diff: https://reviewboard.asterisk.org/r/565/diff
> 
> 
> Testing
> -------
> 
> Running patched 1.6.2.6 on our production network.  Seems to work fine.
> 
> 
> Thanks,
> 
> pprindeville
> 
>