[asterisk-dev] [Code Review] ETSI Explicit Call Transfer (ECT) support. (Asterisk portion)

[rmudgett at digium.com]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/520/
-----------------------------------------------------------

(Updated 2010-04-22 11:35:35.558651)


Review request for Asterisk Developers.


Changes
-------

Address review comments.


Summary
-------

Added ability to send and receive ETSI Explicit Call Transfer (ECT) messages to eliminate tromboned calls.

Asterisk already supported initiating the transfer of calls to eliminate tromboned calls to libpri so there was nothing to do for the asterisk portion.

The libpri API was extended to indicate to asterisk that the far end requests the transfer of the indicated calls.

This is a two part review request.  Asterisk and libpri.  This is the asterisk portion.
https://reviewboard.asterisk.org/r/521/ is the libpri portion.


Diffs (updated)
-----

  /trunk/CHANGES 258490 
  /trunk/channels/chan_dahdi.c 258490 
  /trunk/channels/sig_pri.h 258490 
  /trunk/channels/sig_pri.c 258490 
  /trunk/configs/chan_dahdi.conf.sample 258490 
  /trunk/configure.ac 258490 

Diff: https://reviewboard.asterisk.org/r/520/diff


Testing
-------

A -- *1 -- *2  -- B&C

Party A is on an ISDN phone.

A calls B
A puts B on hold
A calls C
A hangs up to initiate transfer
The B and C parties are now connected to each other and the calls are only connected through *2.

A calls B
A puts B on hold
A calls C
A puts C on hold to retrieve B
A hangs up to initiate transfer
The B and C parties are now connected to each other and the calls are only connected through *2.

Repeat the above two tests but party A uses the EctExecute message instead of disconnecting to transfer the calls.

All four tests passed.


Thanks,

rmudgett