[asterisk-dev] [Code Review] Allow passing multiple arguments to applications specified in features.conf

Tilghman Lesher tlesher at digium.com
Wed Apr 14 17:34:45 CDT 2010



> On 2010-04-14 11:07:14, David Vossel wrote:
> > /trunk/configs/features.conf.sample, lines 79-102
> > <https://reviewboard.asterisk.org/r/547/diff/1/?file=8524#file8524line79>
> >
> >     The syntax for this changed when the <Application> contains both the application name and the arguments in (). As you have it written now, when this is the case the <AppArguments> part of the syntax becomes the MOH_CLASS.  I know this is intended behavior, but it isn't clear to me in this documentation the proper way to set the MOH_CLASS in that case.  I can see how someone might expect feature => #9,peer,Application(arg1,arg2),,mohclass to work, but in that case the mohclass will be overwritten.

Description updated.


- Tilghman


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/547/#review1832
-----------------------------------------------------------


On 2010-04-14 17:34:22, Tilghman Lesher wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/547/
> -----------------------------------------------------------
> 
> (Updated 2010-04-14 17:34:22)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> Yet another case where the conversion of the application delimiter to comma caused an issue.
> 
> 
> This addresses bug 16646.
>     https://issues.asterisk.org/view.php?id=16646
> 
> 
> Diffs
> -----
> 
>   /trunk/configs/features.conf.sample 257187 
>   /trunk/main/features.c 257187 
> 
> Diff: https://reviewboard.asterisk.org/r/547/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Tilghman
> 
>




More information about the asterisk-dev mailing list