[asterisk-dev] [Code Review] SIP: Pineapple

[Olle E. Johansson]

22 okt 2009 kl. 19.03 skrev Alex Hermann:

> On Thursday 22 October 2009, Kevin P. Fleming wrote:
>> Along that line, I'm a couple of days away from being able to make
>> 'pedantic mode dialog matching' the default, which required adding  
>> some
>> functionality to astobj2 so that pedantic-mode matching would no  
>> longer
>> require traversing the entire container of SIP dialogs. In addition,
>> this patch will add parsing and matching of Via header branch-ID  
>> tags,
>> which will solve some problems that occur when Asterisk receives  
>> forked
>> requests from SIP proxies.
Kevin: THis is a bug in 1.4 as well and needs to be fixed there. It  
has appeared
after the "spiral" fixes.

>
> I don't know if you've already started coding, but I'm carrying a  
> patch
> along for several years that fixes exactly both those issues (the  
> astobj2
> part is obviously a bit newer). Just never took the effort of  
> submitting it
> as almost every previous attempt that I've seen in the issue tracker  
> to make
> Asterisk more RFC compliant was rejected or not understood by  
> upstream. If
> there's interest I'll try to free some resources to properly submit  
> it to
> the tracker.
I would love to see that patch in the bug tracker. Post a note when  
you have it,
or find me on line.

>
> In addition it fixes the currently broken 'pedantic' behaviour to be  
> almost
> RFC compliant.
>
Great.

/O