[asterisk-dev] [Code Review] SIP: Pineapple

[Kevin P. Fleming]

Alex Hermann wrote:
> On Thursday 22 October 2009, Kevin P. Fleming wrote:
>> Along that line, I'm a couple of days away from being able to make
>> 'pedantic mode dialog matching' the default, which required adding some
>> functionality to astobj2 so that pedantic-mode matching would no longer
>> require traversing the entire container of SIP dialogs. In addition,
>> this patch will add parsing and matching of Via header branch-ID tags,
>> which will solve some problems that occur when Asterisk receives forked
>> requests from SIP proxies.
> 
> I don't know if you've already started coding, but I'm carrying a patch 
> along for several years that fixes exactly both those issues (the astobj2 
> part is obviously a bit newer). Just never took the effort of submitting it 
> as almost every previous attempt that I've seen in the issue tracker to make 
> Asterisk more RFC compliant was rejected or not understood by upstream. If 
> there's interest I'll try to free some resources to properly submit it to 
> the tracker.
> 
> In addition it fixes the currently broken 'pedantic' behaviour to be almost 
> RFC compliant.

That would absolutely be welcome; it'd be nice if we could have all this
stuff in good enough shape so that when Asterisk 1.8 is ready to be beta
tested we can just enable 'pedantic' mode by default.

-- 
Kevin P. Fleming
Digium, Inc. | Director of Software Technologies
445 Jan Davis Drive NW - Huntsville, AL 35806 - USA
skype: kpfleming | jabber: kpfleming at digium.com
Check us out at www.digium.com & www.asterisk.org