[asterisk-dev] [Code Review] SIP: Pineapple

Alex Hermann alex at speakup.nl
Fri Oct 23 04:40:52 CDT 2009


On Friday 23 October 2009, Olle E. Johansson wrote:
> 22 okt 2009 kl. 19.03 skrev Alex Hermann:
> > On Thursday 22 October 2009, Kevin P. Fleming wrote:
> >> Along that line, I'm a couple of days away from being able to make
> >> 'pedantic mode dialog matching' the default, which required adding
> >> some
> >> functionality to astobj2 so that pedantic-mode matching would no
> >> longer
> >> require traversing the entire container of SIP dialogs. In addition,
> >> this patch will add parsing and matching of Via header branch-ID
> >> tags,
> >> which will solve some problems that occur when Asterisk receives
> >> forked
> >> requests from SIP proxies.
>
> Kevin: THis is a bug in 1.4 as well and needs to be fixed there. It
> has appeared
> after the "spiral" fixes.
I have a patch for 1.4 too.


> > I don't know if you've already started coding, but I'm carrying a
> > patch
> > along for several years that fixes exactly both those issues (the
> > astobj2
> > part is obviously a bit newer).
>
> I would love to see that patch in the bug tracker. Post a note when
> you have it,
It is posted, but awaiting licence approval.

-- 
Greetings,

Alex Hermann
SpeakUp BV




More information about the asterisk-dev mailing list