[asterisk-dev] Insulting source code comments in main/channel.c

[Floimair Florian]

Hi guys!

 

While reading through some of the code today I came across this in main/channel.c (line no. 655 in 1.4.27)

 

/*! \brief Pick the best audio codec */

int ast_best_codec(int fmts)

{

      /* This just our opinion, expressed in code.  We are asked to choose

         the best codec to use, given no information */

      int x;

      static int prefs[] =

      {

            /*! Okay, ulaw is used by all telephony equipment, so start with it */

            AST_FORMAT_ULAW,

            /*! Unless of course, you're a silly European, so then prefer ALAW */

            AST_FORMAT_ALAW,

...

 

Well, what can I say. I'm European but I'm definitely not silly. This is not only insulting but also very narrow-minded. Therefore I kindly request you to remove the "silly" from the comment in the code.

 

I have no idea who is responsible for that but for an open source project I suppose that a lot of people have had a look on this and did not offend, which is kind of awkward.

Also I would like to note that u-law is the suitable codec for North America and Japan, while the majority of the rest of the world uses a-law (so the "comment" would in fact better fit to the Americans/Japanese and u-law). 

 

But enough of the talk. Please just remove the word "silly" from the comment and everyone should be fine.

 

 

 

With best regards

Florian Floimair
Firmware Development

COMMEND INTERNATIONAL GMBH
A-5020 Salzburg, Saalachstraße 51
Tel: +43-662-85 62 25
Sip: f.floimair at commend.com <sip:f.floimair at commend.com> 
Fax: +43-662-85 62 26
f.floimair at commend.com <mailto:f.floimair at commend.com> 
http://www.commend.com <http://www.commend.com/> 

Security and Communication by Commend

FN 178618z | LG Salzburg

 

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://lists.digium.com/pipermail/asterisk-dev/attachments/20091123/30ec6df3/attachment-0001.htm