[asterisk-dev] [Code Review] Fix EIVR socket client interface

thedavidfactor at gmail.com thedavidfactor at gmail.com
Sat Nov 21 15:01:58 CST 2009


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/435/#review1272
-----------------------------------------------------------



/trunk/apps/app_externalivr.c
<https://reviewboard.asterisk.org/r/435/#comment2937>

    This is only needed because ast_gethostbyname doesn't set h_length if an ip address is passed to in instead of a name. This is being addressed by issue 16135, but I would prefer that this fix work without be dependent on any other fix unless there is a good argument against that.


- thedavidfactor


On 2009-11-21 15:01:35, thedavidfactor wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/435/
> -----------------------------------------------------------
> 
> (Updated 2009-11-21 15:01:35)
> 
> 
> Review request for Asterisk Developers and Chris Tooley.
> 
> 
> Summary
> -------
> 
> Fix socket client interface. These few simple fixes allow the previously implemented socket interface to work.
> 
> 
> This addresses bug 16121.
>     https://issues.asterisk.org/view.php?id=16121
> 
> 
> Diffs
> -----
> 
>   /trunk/apps/app_externalivr.c 230584 
> 
> Diff: https://reviewboard.asterisk.org/r/435/diff
> 
> 
> Testing
> -------
> 
> using this in active production
> 
> 
> Thanks,
> 
> thedavidfactor
> 
>




More information about the asterisk-dev mailing list