[asterisk-dev] [Code Review] Basic app_externalivr clean up

[thedavidfactor at gmail.com]

> On 2009-11-13 13:31:44, Chris Tooley wrote:
> > /trunk/apps/app_externalivr.c, line 450
> > <https://reviewboard.asterisk.org/r/428/diff/1/?file=7501#file7501line450>
> >
> >     I think this should be inside an else, otherwise we answer even if they have the run_dead flag set, don't we?

This is handled because immediately before this call it does a "goto exit" if it's running with the run_dead flag set.


- thedavidfactor


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/428/#review1253
-----------------------------------------------------------


On 2009-11-16 09:48:37, thedavidfactor wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/428/
> -----------------------------------------------------------
> 
> (Updated 2009-11-16 09:48:37)
> 
> 
> Review request for Asterisk Developers and Chris Tooley.
> 
> 
> Summary
> -------
> 
> This is the first of several patches for ExternalIVR. My goal is to clean up the messages and argument parsing. All the debug messages and a lot of the log messages have been changed to verbose messages. All errors that result in EIVR ending prematurely or unexpectedly are now logged as errors. This is the first draft so comments/question are solicited.
> 
> 
> Diffs
> -----
> 
>   /trunk/apps/app_externalivr.c 229668 
> 
> Diff: https://reviewboard.asterisk.org/r/428/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> thedavidfactor
> 
>