[asterisk-dev] [Code Review] Basic app_externalivr clean up

[Russell Bryant]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/428/#review1261
-----------------------------------------------------------

Ship it!


The code looks fine to commit.  These couple of comments are just minor suggestions.


/trunk/apps/app_externalivr.c
<https://reviewboard.asterisk.org/r/428/#comment2916>

    I know this code was already like this, but since you're changing the line anyway, there should not be extra spaces right inside the parenthesis.



/trunk/apps/app_externalivr.c
<https://reviewboard.asterisk.org/r/428/#comment2917>

    An alternative way to make this code more clear would be to add defines for the commands.
    
    #define EIVR_CMD_SET 'S'
    
    ...
    
    } else if (input[0] == EIVR_CMD_SET) {


- Russell


On 2009-11-16 11:52:57, thedavidfactor wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/428/
> -----------------------------------------------------------
> 
> (Updated 2009-11-16 11:52:57)
> 
> 
> Review request for Asterisk Developers and Chris Tooley.
> 
> 
> Summary
> -------
> 
> This is the first of several patches for ExternalIVR. My goal is to clean up the messages and argument parsing. All the debug messages and a lot of the log messages have been changed to verbose messages. All errors that result in EIVR ending prematurely or unexpectedly are now logged as errors. This is the first draft so comments/question are solicited.
> 
> 
> Diffs
> -----
> 
>   /trunk/apps/app_externalivr.c 229668 
> 
> Diff: https://reviewboard.asterisk.org/r/428/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> thedavidfactor
> 
>