[asterisk-dev] [Code Review] Gtalk call from Empathy - no corresponding codecs

[Philippe Sultan]

> On 2009-03-02 23:57:10, Russell Bryant wrote:
> > Can you provide some more information on the difference between iks_child() and iks_next_tag()?  Also, can you provide an example of the XML that was not parsed correctly, with a description of what the change makes the code do differently so that it now works?

David, I see you've made your tests with a 1.4 version of Asterisk. Have you checked a more recent version in the 1.6 series?

I'm asking because bug #12647 (fixed in 1.6) seems pretty close to what you describe.

Apart from this, I think replacing iks_child and iks_next by iks_first_tag and iks_next_tag is a good thing because the latter check the node type. We don't want to process any character data that would have been inserted in a node here. However, I can't really figure out how those changes fixed the described problem. Again, 1.6 or SVN trunk might be worth a try. Can you post your results to bug report #14223?


- Philippe


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.digium.com/r/181/#review497
-----------------------------------------------------------


On 2009-03-02 17:14:16, dbrooks wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.digium.com/r/181/
> -----------------------------------------------------------
> 
> (Updated 2009-03-02 17:14:16)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> This is a simple patch that fixes an issue where the iksemel library was seemingly incorrectly parsing call negotiation xml resulting in chan_gtalk not seeing ulaw supported on one end, failing the call from Empathy. This bug occurred on my personal machine, and is remedied by simply using similar, safer iksemel function calls.
> 
> 
> This addresses bugs 0012647 and 0014223.
>     http://bugs.digium.com/view.php?id=0012647
>     http://bugs.digium.com/view.php?id=0014223
> 
> 
> Diffs
> -----
> 
>   /branches/1.4/channels/chan_gtalk.c 179460 
> 
> Diff: http://reviewboard.digium.com/r/181/diff
> 
> 
> Testing
> -------
> 
> This patch has been tested with asterisk 1.4, iksemel 1.3, Empathy 2.24.1, Polycom SoundPoint IP 430 SIP on Ubuntu Intrepid Ibex 8.10 linux 2.6.27-11-generic x86_64
> 
> 
> Thanks,
> 
> dbrooks
> 
>