[asterisk-dev] [Code Review] app_meetme not setting filename and fileformat correctly when recording

[Russell Bryant]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.digium.com/r/180/#review498
-----------------------------------------------------------



/trunk/apps/app_meetme.c
<http://reviewboard.digium.com/r/180/#comment1151>

    I don't think 4 is bug enough.  We have some format extensions that are 4 characters minus the null terminator.



/trunk/apps/app_meetme.c
<http://reviewboard.digium.com/r/180/#comment1152>

    Ideally, all of this code should be checking for memory allocation failure.



/trunk/apps/app_meetme.c
<http://reviewboard.digium.com/r/180/#comment1153>

    space after comma



/trunk/apps/app_meetme.c
<http://reviewboard.digium.com/r/180/#comment1154>

    no C++ style comments



/trunk/apps/app_meetme.c
<http://reviewboard.digium.com/r/180/#comment1155>

    There is a potential memory leak here.  You call ast_strdup() and save the result in cnf->recordingfilename just a few lines earlier and just overwrite it here.



/trunk/apps/app_meetme.c
<http://reviewboard.digium.com/r/180/#comment1156>

    You have another memory leak here.



/trunk/apps/app_meetme.c
<http://reviewboard.digium.com/r/180/#comment1157>

    more C++ comments that need to die



/trunk/apps/app_meetme.c
<http://reviewboard.digium.com/r/180/#comment1158>

    memory leak



/trunk/apps/app_meetme.c
<http://reviewboard.digium.com/r/180/#comment1159>

    memory leak


- Russell


On 2009-02-27 16:44:47, David Vossel wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.digium.com/r/180/
> -----------------------------------------------------------
> 
> (Updated 2009-02-27 16:44:47)
> 
> 
> Review request for Asterisk Developers and Russell Bryant.
> 
> 
> Summary
> -------
> 
> When app_meetme gets a realtime conference, it doesn't get the filename and fileformat correctly when 'r' is set.  Now app_meetme first checks to see if fileformat and filename are declared in the db, if they're not it checks the .conf file, if its not declared there either it then uses defaults. 
> 
> 
> This addresses bug 0014545.
>     http://bugs.digium.com/view.php?id=0014545
> 
> 
> Diffs
> -----
> 
>   /trunk/apps/app_meetme.c 179055 
> 
> Diff: http://reviewboard.digium.com/r/180/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> David
> 
>