[asterisk-dev] [Code Review] Gtalk call from Empathy - no corresponding codecs

[Russell Bryant]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.digium.com/r/181/#review497
-----------------------------------------------------------


Can you provide some more information on the difference between iks_child() and iks_next_tag()?  Also, can you provide an example of the XML that was not parsed correctly, with a description of what the change makes the code do differently so that it now works?

- Russell


On 2009-03-02 17:14:16, dbrooks wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.digium.com/r/181/
> -----------------------------------------------------------
> 
> (Updated 2009-03-02 17:14:16)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> This is a simple patch that fixes an issue where the iksemel library was seemingly incorrectly parsing call negotiation xml resulting in chan_gtalk not seeing ulaw supported on one end, failing the call from Empathy. This bug occurred on my personal machine, and is remedied by simply using similar, safer iksemel function calls.
> 
> 
> This addresses bugs 0012647 and 0014223.
>     http://bugs.digium.com/view.php?id=0012647
>     http://bugs.digium.com/view.php?id=0014223
> 
> 
> Diffs
> -----
> 
>   /branches/1.4/channels/chan_gtalk.c 179460 
> 
> Diff: http://reviewboard.digium.com/r/181/diff
> 
> 
> Testing
> -------
> 
> This patch has been tested with asterisk 1.4, iksemel 1.3, Empathy 2.24.1, Polycom SoundPoint IP 430 SIP on Ubuntu Intrepid Ibex 8.10 linux 2.6.27-11-generic x86_64
> 
> 
> Thanks,
> 
> dbrooks
> 
>