[asterisk-dev] [Code Review] SIP register not using peer's outbound proxy

[Mark Michelson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/294/#review963
-----------------------------------------------------------

Ship it!


Just take care of the one thing I mentioned below and I'll be all right with this change.

You may also want to document in the code the reason why the [peername?] is not being documented in sip.conf


/trunk/channels/chan_sip.c
<https://reviewboard.asterisk.org/r/294/#comment2302>

    Any reason why you used strrchr instead of strchr? In my mind, strchr seems more appropriate.


- Mark


On 2009-07-10 15:48:22, David Vossel wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/294/
> -----------------------------------------------------------
> 
> (Updated 2009-07-10 15:48:22)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> If callbackextension is defined for a peer it successfully causes a registration to occur, but the registration ignores the outboundproxy settings for the peer.  This is because the call to obproxy_get() in transmit_register() is not capable of passing a peer.  This patch adds the peername option, [peername?], to the register string allowing transmit_register to attempt to find the peer and use it's outbound proxy.
> 
> register => [peername?][transport://]user[@domain][:secret[:authuser]]@host[:port][/extension][~expiry]
> 
> 
> This addresses bug 14344.
>     https://issues.asterisk.org/view.php?id=14344
> 
> 
> Diffs
> -----
> 
>   /trunk/channels/chan_sip.c 205840 
> 
> Diff: https://reviewboard.asterisk.org/r/294/diff
> 
> 
> Testing
> -------
> 
> tested register parsing and verified peer proxy is used over global proxy when [peername?] is specified.
> 
> 
> Thanks,
> 
> David
> 
>