[asterisk-dev] [Code Review] SIP register not using peer's outbound proxy

[David Vossel]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/294/
-----------------------------------------------------------

(Updated 2009-07-10 15:48:22.155887)


Review request for Asterisk Developers.


Changes
-------

peername is now only used internally for registrations when callbackextension is defined for a peer.


Summary
-------

If callbackextension is defined for a peer it successfully causes a registration to occur, but the registration ignores the outboundproxy settings for the peer.  This is because the call to obproxy_get() in transmit_register() is not capable of passing a peer.  This patch adds the peername option, [peername?], to the register string allowing transmit_register to attempt to find the peer and use it's outbound proxy.

register => [peername?][transport://]user[@domain][:secret[:authuser]]@host[:port][/extension][~expiry]


This addresses bug 14344.
    https://issues.asterisk.org/view.php?id=14344


Diffs (updated)
-----

  /trunk/channels/chan_sip.c 205840 

Diff: https://reviewboard.asterisk.org/r/294/diff


Testing
-------

tested register parsing and verified peer proxy is used over global proxy when [peername?] is specified.


Thanks,

David