[asterisk-dev] Changing function name of a static function and updating doxygen doc in 1.4
Olle E. Johansson
oej at edvina.net
Sat Dec 5 03:25:49 CST 2009
4 dec 2009 kl. 18.21 skrev SVN commits to the Digium repositories:
> Author: dvossel
> Date: Fri Dec 4 11:21:34 2009
> New Revision: 233116
> URL: http://svnview.digium.com/svn/asterisk?view=rev&rev=233116
> document and rename strip_control() in app_voicemail
I just wanted to discuss whether this kind of patches that doesn't change any functionality belongs in released code. It doesn't add to user documentation either.
There are many sites out there that keeps track on all patches to release code, which are supposed to be bug fixes only (and admin documentation upgrades). I don't see this change belonging in that category.
I know it doesn't hurt, but it adds un-necessary work to the review process of the admins of these systems. I would like us to avoid these kind of changes to releases in the future. It belongs and should often be done to trunk though.
Just my 10 cents.
More information about the asterisk-dev