[asterisk-dev] [svn-commits] lmadsen: trunk r149040 - /trunk/doc/manager_1_1.txt

[Johansson Olle E]

15 okt 2008 kl. 10.51 skrev Kevin P. Fleming:

> Johansson Olle E wrote:
>
>> We could propably use the event name "Registry" for this too. We're
>> using "Status" instead of "State" in many cases, like "PeerStatus". I
>> don't like using generic names like "State", "RegisterState" makes
>> more sense and is more unique.
>>
>> We need to use the same headers as other events and this doesn't even
>> attempt to do that.
>
> These two paragraphs are somewhat conflicting; either we use the same
> headers as other events or we don't. There is no need for the  
> 'State' to
> be 'RegisterState' when it is already embedded inside a 'Registry'
> event; there is no expectation that any event headers will be
> understandable without the entire context of the event they are part  
> of.
> I would actually much prefer that we use the exact same header name  
> for
> the same type of information, regardless of which event type it is
> embedded into.

Right, so using "Host:" in one event and "Domain" in another event is  
wrong.

The question remains: Should we consider this a bug and change 1.6.0?

This patch should not have been approved in the first time, but now  
we're
beyond that.

/O