[asterisk-dev] [Code Review] Convert open coded lists in indications to linked list macros

Sean Bright sean.bright at gmail.com
Thu Nov 6 15:42:22 CST 2008

This is an automatically generated e-mail. To reply, visit:

(Updated 2008-11-06 15:42:22.332392)

Review request for Asterisk Developers.


Fixed a log error I introduced in ast_register_indication that would re-insert an indication even if it was already in the list.


(I added this before but I guess I did something wrong when I published it)

This patch converts the open coded linked list in the indications code to use the AST_LIST_* macros.  Using the list macros is less error prone and reduces the amount of code needed to manage the structures.

But honestly, my main motivation for writing this was to bump up my C skills on ohloh.

Diffs (updated)

  /trunk/include/asterisk/indications.h 155080 
  /trunk/main/indications.c 155080 
  /trunk/res/res_indications.c 155080 

Diff: http://reviewboard.digium.com/r/34/diff




More information about the asterisk-dev mailing list