[asterisk-dev] [Code Review] Convert open coded lists in indications to linked list macros
Sean Bright
sean.bright at gmail.com
Thu Nov 6 15:19:34 CST 2008
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.digium.com/r/34/#review90
-----------------------------------------------------------
This is incorrect. It will insert even if it's already there. Will re-work.
- Sean
On 2008-11-06 13:43:14, Sean Bright wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.digium.com/r/34/
> -----------------------------------------------------------
>
> (Updated 2008-11-06 13:43:14)
>
>
> Review request for Asterisk Developers.
>
>
> Summary
> -------
>
> (I added this before but I guess I did something wrong when I published it)
>
> This patch converts the open coded linked list in the indications code to use the AST_LIST_* macros. Using the list macros is less error prone and reduces the amount of code needed to manage the structures.
>
> But honestly, my main motivation for writing this was to bump up my C skills on ohloh.
>
>
> Diffs
> -----
>
> /trunk/include/asterisk/indications.h 154965
> /trunk/main/indications.c 154965
> /trunk/res/res_indications.c 154965
>
> Diff: http://reviewboard.digium.com/r/34/diff
>
>
> Testing
> -------
>
>
> Thanks,
>
> Sean
>
>
More information about the asterisk-dev
mailing list