[asterisk-dev] [Code Review] Convert open coded lists in indications to linked list macros

[Russell Bryant]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.digium.com/r/34/#review95
-----------------------------------------------------------

Ship it!


As far as the list conversion goes, this is good to go.

There are still the larger issues of object management in this code in general, but that is unrelated to these changes.

- Russell


On 2008-11-06 15:42:22, Sean Bright wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.digium.com/r/34/
> -----------------------------------------------------------
> 
> (Updated 2008-11-06 15:42:22)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> (I added this before but I guess I did something wrong when I published it)
> 
> This patch converts the open coded linked list in the indications code to use the AST_LIST_* macros.  Using the list macros is less error prone and reduces the amount of code needed to manage the structures.
> 
> But honestly, my main motivation for writing this was to bump up my C skills on ohloh.
> 
> 
> Diffs
> -----
> 
>   /trunk/include/asterisk/indications.h 155080 
>   /trunk/main/indications.c 155080 
>   /trunk/res/res_indications.c 155080 
> 
> Diff: http://reviewboard.digium.com/r/34/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Sean
> 
>