[asterisk-dev] Notify with Caller ID

Johansson Olle E oej at edvina.net
Tue Nov 4 13:45:40 CST 2008

4 nov 2008 kl. 20.31 skrev Russell Bryant:

> Johansson Olle E wrote:
>> Implementing a channel walk for each notify was exactly the reason  
>> why
>> we have
>> not accepted all the patches for SNOM pickup... I don't really agree
>> with this,
>> unless there has been huge changes to channel walks.
>> We have to get the information from the source, the sending channel,
>> instead of retrieving it in the actual notify. There's a couple of  
>> items
>> we want to add as attachments in that case, so we might want to
>> discuss this.
>> If this code was in the bug tracker, I would not accept it for the
>> same reasons
>> we did not accept the SNOM pickup code.
> There were certainly bigger reasons why the original patch was not
> accepted.  The patch was completely SIP specific.  There was no way it
> would work at all if the caller was not a SIP channel or if the
> extension being monitored was not a SIP channel.  The new code is
> technology independent.
> Now, I do agree that walking the channel list is quite expensive.   
> This
> is part of the reason why this was made an option.  (The second is  
> that
> it doesn't support all possible scenarios based on some architectural
> problems.)


You're rewriting history., The one and only thing was the channel walks.
I had many discussions about this and made that decision while I was
the maintainer of the SIP channel. To make sure we only did this
for SIP channels was easy and I had solutions for other types of
channels in code too.

It harms the process to suddenly accept this while we've been denying
it before. Time to use your veto card that you have been waving with
so quickly before instead of protecting yet another bad patch.

Bad code should not be accepted just because "it works on small
systems". The real reason here is that you have to solve it since
you have a paying customer. That's not a good reason to accept
bad code.

But have it your way. The are bigger things to fix in the SIP channel.


More information about the asterisk-dev mailing list