[asterisk-dev] [zaptel-commits] tzafrir: branch 1.4 r3708 - in /branches/1.4: zaptel-base.c zaptel.h zconfig.h

Kevin P. Fleming kpfleming at digium.com
Tue Jan 22 11:17:04 CST 2008


SVN commits to the Zaptel project wrote:

> @@ -6860,6 +6865,10 @@
>  {
>  	unsigned char silly[ZT_CHUNKSIZE];
>  	/* Called with chan->lock locked */
> +#ifdef	OPTIMIZE_CHANMUTE
> +	if(likely(chan->chanmute))
> +		return;
> +#endif
>  	if (!buf)
>  		buf = silly;
>  	__zt_getbuf_chunk(chan, buf);

Shouldn't these be unlikely() instead of likely()? Even if someone
enables this code, it's still far more likely that their channels will
be in 'I need data' mode than not, especially since none of the
low-level drivers currently support this flag.

-- 
Kevin P. Fleming
Director of Software Technologies
Digium, Inc. - "The Genuine Asterisk Experience" (TM)



More information about the asterisk-dev mailing list