[asterisk-dev] [zaptel-commits] tzafrir: branch 1.4 r3708 - in /branches/1.4: zaptel-base.c zaptel.h zconfig.h

[Tzafrir Cohen]

On Tue, Jan 22, 2008 at 11:17:04AM -0600, Kevin P. Fleming wrote:
> SVN commits to the Zaptel project wrote:
> 
> > @@ -6860,6 +6865,10 @@
> >  {
> >  	unsigned char silly[ZT_CHUNKSIZE];
> >  	/* Called with chan->lock locked */
> > +#ifdef	OPTIMIZE_CHANMUTE
> > +	if(likely(chan->chanmute))
> > +		return;
> > +#endif
> >  	if (!buf)
> >  		buf = silly;
> >  	__zt_getbuf_chunk(chan, buf);
> 
> Shouldn't these be unlikely() instead of likely()? Even if someone
> enables this code, it's still far more likely that their channels will
> be in 'I need data' mode than not, especially since none of the
> low-level drivers currently support this flag.

Consider the case of a PBX with 200 analog extensions and 1 E1 trunk.
Let's assume a capacity of 25% for the analog extensions.

So we normally have some 50 (analog) + 31 (digital) channels open. And
we have 150 (analog) channels unused. So definetly more unused than
used.

And those were quite pessimistic capacity figures.


It would not help a bit if all of your channels go thrrough digital
Zaptel channels. 

-- 
               Tzafrir Cohen
icq#16849755              jabber:tzafrir.cohen at xorcom.com
+972-50-7952406           mailto:tzafrir.cohen at xorcom.com
http://www.xorcom.com  iax:guest at local.xorcom.com/tzafrir