[asterisk-dev] [asterisk-commits] russell: trunk r97643 - /trunk/configure.ac

[Luigi Rizzo]

On Wed, Jan 09, 2008 at 10:51:16PM -0000, SVN commits to the Asterisk project wrote:
> Author: russell
> Date: Wed Jan  9 16:51:15 2008
> New Revision: 97643
> 
> URL: http://svn.digium.com/view/asterisk?view=rev&rev=97643
> Log:
> re-add check for gtk1, which is used for pbx_gtkconsole

just to understand, what was the problem with the
AST_EXT_TOOL_CHECK([GTK], [gtk])
version ? Missing --cflags gthread or --libs gthread ?
In case it would be preferable to expand the AST_EXT_TOOL_CHECK
macro to include optional arguments (or maybe already does this)
than to expand it inline in configure.ac

The comment "we don't use gtk right now..." is only to say
that we make no use of the result of the check, but we do check.

cheers
luigi

> 
> Modified:
>     trunk/configure.ac
> 
> Modified: trunk/configure.ac
> URL: http://svn.digium.com/view/asterisk/trunk/configure.ac?view=diff&rev=97643&r1=97642&r2=97643
> ==============================================================================
> --- trunk/configure.ac (original)
> +++ trunk/configure.ac Wed Jan  9 16:51:15 2008
> @@ -1225,8 +1225,17 @@
>  AST_EXT_LIB_CHECK([X11], [X11], [XOpenDisplay], [X11/Xlib.h],,, [standard_path])
>  AST_EXT_LIB_CHECK([X11], [X11], [XOpenDisplay], [X11/Xlib.h],, [-I/usr/X11R6/include], [X11R6])
>  
> -# we don't use gtk right now...
> -AST_EXT_TOOL_CHECK([GTK], [gtk])
> +PBX_GTK=0
> +AC_CHECK_TOOL(GTKCONFIG, gtk-config, No)
> +if test ! "x${GTKCONFIG}" = xNo; then
> +   GTK_INCLUDE=$(${GTKCONFIG} --cflags gthread)
> +   GTK_LIB=$(${GTKCONFIG} --libs gthread)
> +   PBX_GTK=1
> +   AC_DEFINE([HAVE_GTK], 1, [Define if your system has the GTK libraries.])
> +fi
> +AC_SUBST(PBX_GTK)
> +AC_SUBST(GTK_INCLUDE)
> +AC_SUBST(GTK_LIB)
>  
>  PBX_GTK2=0
>  AC_CHECK_TOOL(PKGCONFIG, pkg-config, No)
> 
> 
> _______________________________________________
> --Bandwidth and Colocation Provided by http://www.api-digital.com--
> 
> asterisk-commits mailing list
> To UNSUBSCRIBE or update options visit:
>    http://lists.digium.com/mailman/listinfo/asterisk-commits